-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
isl: update to 0.23 (with cloog and soname) #29104
Conversation
See also #24424 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're updating two packages here, you should have a commit for each.
@ericonr Thanks, I think I fixed it. |
Looks good to me, I compiled sagemath-9.2 using this without any issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The isl commit message should mention that it's fixing the license and homepage.
@ericonr is the |
Ok, I think the cloog commit should mention that it's changing the distfiles origin, but otherwise LGTM. Just fix the commit message and we are good. |
@ericonr Done. |
General
Have the results of the proposed changes been tested?